Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 support for noetic #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

python3 support for noetic #16

wants to merge 2 commits into from

Conversation

k-okada
Copy link

@k-okada k-okada commented Feb 24, 2022

in addition to #14 ,

Fix python3 syntax error

SyntaxError: invalid syntax                                                                       
[Testcase: testtest_camera_info_manager_py] ... FAILURE!                                          
FAILURE: False is not true : test [test_camera_info_manager_py] did not generate test results     
  File "/usr/lib/python3.8/unittest/case.py", line 60, in testPartExecutor                        
    yield                                                                                         
  File "/usr/lib/python3.8/unittest/case.py", line 676, in run                                    
    self._callTestMethod(testMethod)                                                              
  File "/usr/lib/python3.8/unittest/case.py", line 633, in _callTestMethod                        
    method()                                                                                      
  File "/opt/ros/noetic/lib/python3/dist-packages/rostest/runner.py", line 164, in fn             
    self.assert_(os.path.isfile(test_file), "test [%s] did not generate test results"%test_name)  
  File "/usr/lib/python3.8/unittest/case.py", line 1410, in deprecated_func                       
    return original_func(*args, **kwargs)                                                         
  File "/usr/lib/python3.8/unittest/case.py", line 765, in assertTrue                             
    raise self.failureException(msg)                                                              --------------------------------------------------------------------------------                  
                                                                                                  [ROSTEST]-----------------------------------------------------------------------                  
                                                                                                  
[testtest_camera_info_manager_py][failed]                                                                                                                                                           
SUMMARY                                                                                            * RESULT: FAIL                                                                                   
 * TESTS: 0                                                                                       
 * ERRORS: 0                                                                                       * FAILURES: 1  
 * ```

@k-okada k-okada changed the title python3 support python3 support for noetic Feb 24, 2022
@k-okada k-okada mentioned this pull request Feb 24, 2022
Open
@StohanzlMart
Copy link

Pretty please can you @jack-oquin or anyone from ROS Perception team please merge?

Thank you!

@Timple
Copy link

Timple commented Jan 11, 2023

Either all are ignoring your call or nobody is subscribed to this repository or PR. Shamelessly tagging @JWhitleyWork as the last person to have committed in the ros-perception stack.

Perhaps he can make the effort or can point us to the right person to tag 🙂

@JWhitleyWork
Copy link

@Timple Unfortunately, I don't have maintainer access to this repo. However, it's pretty small and I'm already managing image_pipeline, so why not? Just in-case, I think @lucasw also has access to do what this needs. If not, I'll make a post on ROS Discourse to ask about becoming the maintainer.

@v4hn
Copy link

v4hn commented Jan 24, 2023

Go for it @JWhitleyWork . If @lucasw had the access he wouldn't need to file pull-requests for obvious things and leave them for two years.

For now I merged both changes into https://github.com/ros-o/camera_info_manager_py (ros-o didn't exist yet when these PRs were created), but that doesn't fix it for ROS noetic of course.

@Timple
Copy link

Timple commented Feb 2, 2023

Yes please, @JWhitleyWork go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k-okada @StohanzlMart @Timple @JWhitleyWork @v4hn @lucasw